[MIRROR] Kills spec_updatehealth, replaces it with use of COMSIG_LIVING_HEALTH_UPDATE
#766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IVING_HEALTH_UPDATE` [MDB IGNORE] (#24152) * Kills `spec_updatehealth`, replaces it with use of `COMSIG_LIVING_HEALTH_UPDATE` * Diffs --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Giz <[email protected]>
Steals-The-PRs
added
Mirroring conflict
…into upstream-mirror-24152
AnywayFarus
added a commit
that referenced
this pull request
Nov 23, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 4, 2024
…s. (#766) * Fixes burning a bible giving you an infinite amount of curses. (#81248) ## About The Pull Request Burning a bible now gives you 1 curse, instead of INFINITY curses. ## Why It's Good For The Game It looks like tgstation/tgstation#78899 forgot about bible curses. I think this was an oversight. ## Changelog :cl: fix: burning a bible no longer gives you INFINITY curses /:cl: * Fixes burning a bible giving you an infinite amount of curses. --------- Co-authored-by: Xander3359 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24152
Original PR: tgstation/tgstation#78772
About The Pull Request
Quick refactor, replaces
spec_updatehealthwith use ofCOMSIG_LIVING_HEALTH_UPDATE.spec_updatehealthwas only used by one species, ethereals, and it was used in a (in my opinion) janky way by callingspec_updatehealthconstantly.This has one downside -
COMSIG_LIVING_HEALTH_UPDATEis NOT sent if the mob is in godmode, whilespec_updatehealthwas, which means godmoded ethereals may not update 100% accurately according to their health before entering godmode, but I doubt this will come into play often at all.Why It's Good For The Game
updatehealthis kinda hot, not turbo hot but a little hot, so this helps performance a bit.Changelog
🆑 Melbert
refactor: Refactors how ethereals update their color when damaged.
/:cl: